1590453 - Crash in [@ java.nio.channels.OverlappingFileLockException: at sun.nio.ch.SharedFileLockTable.checkList(FileLockTable.java)]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-41406764-4af6-4cca-afda-ed37f0191022.

Seen while looking at fennec release crashes: https://bit.ly/2W5wdII. This crash has been around in previous releases but has no bug. There are no useful comments. Volume seems higher in 68.1 compared to the 68 release.

Some telemetry related stuff in the stack:

at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.lockAndReadFileAndCloseStream(TelemetryJSONFilePingStore.java:302)
at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.lockAndReadJSONFromFile(TelemetryJSONFilePingStore.java:248)
at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.getAllPings(TelemetryJSONFilePingStore.java:171)
at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.getAllPings(TelemetryJSONFilePingStore.java:66)
at org.mozilla.gecko.telemetry.TelemetryUploadService.uploadPendingPingsFromStore(TelemetryUploadService.java:108)
at org.mozilla.gecko.telemetry.TelemetryUploadService.onHandleWork(TelemetryUploadService.java:81)

Affected APIs range from 29 to 24.

Java stack trace:

java.nio.channels.OverlappingFileLockException
	at sun.nio.ch.SharedFileLockTable.checkList(FileLockTable.java:255)
	at sun.nio.ch.SharedFileLockTable.add(FileLockTable.java:152)
	at sun.nio.ch.FileChannelImpl.tryLock(FileChannelImpl.java:1061)
	at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.lockAndReadFileAndCloseStream(TelemetryJSONFilePingStore.java:302)
	at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.lockAndReadJSONFromFile(TelemetryJSONFilePingStore.java:248)
	at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.getAllPings(TelemetryJSONFilePingStore.java:171)
	at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.getAllPings(TelemetryJSONFilePingStore.java:66)
	at org.mozilla.gecko.telemetry.TelemetryUploadService.uploadPendingPingsFromStore(TelemetryUploadService.java:108)
	at org.mozilla.gecko.telemetry.TelemetryUploadService.onHandleWork(TelemetryUploadService.java:81)
	at android.support.v4.app.JobIntentService$CommandProcessor.doInBackground(JobIntentService.java:392)
	at android.support.v4.app.JobIntentService$CommandProcessor.doInBackground(JobIntentService.java:383)
	at android.os.AsyncTask$2.call(AsyncTask.java:316)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
	at java.lang.Thread.run(Thread.java:776)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The crash rate is pretty low, but I'll ask the team to take a peek.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1590453 - Ignore locked ping files; r?VladBaicu

This case where the file would have already been locked, case in which a null
is to be returned is already handled by the caller of the
lockAndReadFileAndCloseStream method -
https://hg.mozilla.org/releases/mozilla-esr68/file/5ed74d712d2cccd2b50eb2b831f5519b621807ae/mobile/android/base/java/org/mozilla/gecko/telemetry/stores/TelemetryJSONFilePingStore.java#l257
We just didn't account for the particular OverlappingFileLockException.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9111236 [details]
Bug 1590453 - Ignore locked ping files; r?VladBaicu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: High volume crash fix.
• User impact if declined: Possible seemingly random crash.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change.
• String or UUID changes made by this patch:

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9111236 [details]
Bug 1590453 - Ignore locked ping files; r?VladBaicu

Fixes a high-volume Fennec crash. Approved for 68.3b6.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/b949a45ec346