1590459 - login list header can wrap localized '<number> logins' on two lines for locales with longer texts

Status: NEW

(Firefox :: about:logins, task, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 70.0, 71.0b3 and 72.0a1 20191022094606 on Windows 8.1

In the header of the login list at the about:logins page, the number of logins is mentioned as <number> logins (for Firefox in English, en-US).

For German, it wraps onto 2 lines:

<number>
Zugangsdaten

The sidebar has a width of 320px, 350px would let the drop down prefix, drop down text and login count fit in one line. Haven't checked other locales.

Comment 1

[Matthew N. [:MattN]]

Katie, what do you think about this? Should we increase the width?

Comment 2

[katieC]

Do we know how wide the Sort By menu gets? I'm wondering if "Breached Websites" in the menu is impacting the available space for "Zugangdaten"'? ...and might be resolved when it's changed to "Alerts"?

Regardless, this issue may arise with other localisation, so the ux recommendation is to keep default width to 320 (as is) and truncate "logins" or "Zugangd..." to fit AND allow the user to change the width of the sidebar (as can be done with the Bookmarks/Library sidebar now). Can we do that?

Comment 3

[Matthew N. [:MattN]]

(Quoting katieC from comment #2)

Do we know how wide the Sort By menu gets? I'm wondering if "Breached Websites" in the menu is impacting the available space for "Zugangdaten"'? ...and might be resolved when it's changed to "Alerts"?

Can you answer the above questions? I'm especially interested in knowing if changing "Breached Websites" to "Alerts" would fix the issue for German?

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #3)

(Quoting katieC from comment #2)

Do we know how wide the Sort By menu gets? I'm wondering if "Breached Websites" in the menu is impacting the available space for "Zugangdaten"'? ...and might be resolved when it's changed to "Alerts"?

Can you answer the above questions? I'm especially interested in knowing if changing "Breached Websites" to "Alerts" would fix the issue for German?

Looking at one locale (German) shouldn't really be the criteria here. It might fix it for German, and break several others.

Side note: there are translations that are much longer than German for this key
https://transvision.mozfr.org/string/?entity=browser/browser/aboutLogins.ftl:login-list-count&repo=gecko_strings

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry for the late reply, this is without "Breached Websites" but only alphabetical sorting and by last used and last changed.