1590467 - Implement minimal UX for running puppeteer with Firefox

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P1)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Get a basic flow working for starting up Firefox with puppeteer, say, via an environment variable or command-line switch.

To get the conversation started, I propose to scope this work to our vendored puppeteer fork, getting it running in our remote(pup) job on Treeherder.

We can iterate from there to propose something more robust to upstream Puppeteer.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

web-platform tests use --product to specify the type of browser. Maybe this could be re-used here for selection. That would also allow us to have a code path beside the puppeteer-firefox code.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also this should not only be for CI but also for local testing.

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: GitHub Pull Request

See GitHub PR for WIP.

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: GitHub Pull Request

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1590467 - Updated vendored puppeteer with proposed browser selection; r=#remote!

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1590467 - Use new testing options in puppeteer-test mach command; r=#remote!

This takes advantage of the browser-selection patch proposed to Puppeteer.
A --product option allows choice between 'firefox' and 'chrome'.
Puppeteer takes care of profile creation for Firefox. Additional Puppeteer
Launcher options can be passed along with --setopt.

Depends on D52313

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/278f81464fc0
Updated vendored puppeteer with proposed browser selection; r=remote-protocol-reviewers,ato
https://hg.mozilla.org/integration/autoland/rev/e2ceb42ddbbf
Use new testing options in puppeteer-test mach command; r=remote-protocol-reviewers,ato

Comment 8

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I'll leave this open until the upstream Puppeteer PR is closed.

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/278f81464fc0
https://hg.mozilla.org/mozilla-central/rev/e2ceb42ddbbf

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The upstream PR got merged:
https://github.com/puppeteer/puppeteer/commit/c5a72e9887098671c3c940e86e181e3f90f1294f

Maja, I assume this bug can be closed now?

Comment 11

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

FYI, something I added on at the end was being able to choose the product programmatically rather than with environment variables, so that there's access to Firefox both in puppeteer and puppeteer-core (which ignores PUPPETEER_* env vars). Examples:

const options = {headless: false, dumpio: true, product: 'firefox', executablePath: 'path/to/firefox', extraPrefsFirefox: {'remote.log.level': 'Trace'}};
const browser = await puppeteer.launch(options);

Comment 12

[Andreas Tolfsen ❲:ato❳]

I guess we still have to rely on the environment variable configuration in remot/mach_commands.py.