1590505 - Drag and drop of calendar events in month and multiweek views doesn't work

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect, P3)

Description

[Paul Morris [:pmorris]]

On trunk, when you try to drag and drop a calendar event (including all day events) in month or multi-week view, the event does not move and the following error appears in the console:

NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIDragService.invokeDragSession] 3 calendar-dnd-listener.js:589
    invokeEventDragSession chrome://calendar/content/calendar-dnd-listener.js:589
    MozCalendarEditableItem chrome://calendar/content/calendar-editable-item.js:123

Looks like bug 1561056 added an additional csp argument to invokeDragSession (in nsIContentSecurityPolicy aCsp) and we haven't caught up yet:
https://searchfox.org/mozilla-central/source/widget/nsIDragService.idl#59

(Seems like we should have a test for dragging and dropping calendar events.)

Comment 1

[Paul Morris [:pmorris]]

Attachment: drag-and-drop-cal-events-0.patch

Well that was simpler than it looked.

Comment 2

[Paul Morris [:pmorris]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e9ccb032e0affc5536f7adb6e61069110609d60b

Comment 3

[Paul Morris [:pmorris]]

Adding "checkin-needed-tb". Let me know if we're still using "checkin-needed" instead.

Comment 4

[Jorg K (CEST = GMT+2)]

If this broke due to bug 1561056, this will need beta uplift. Kindly add it yourself while Geoff's away this week. I'll be building another beta in a few days.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6604dca556d4
Fix drag and drop of calendar events. r=darktrojan

Comment 6

[Paul Morris [:pmorris]]

Comment on attachment 9104229 [details] [diff] [review]
drag-and-drop-cal-events-0.patch

This is indeed needed on beta.  Adding approval for upload since Geoff is out this week.

Comment 7

[Jorg K (CEST = GMT+2)]

TB 71 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/1f60ef9ee3b3a9a102ce7fd8f2121bd8f27bb1f5