Closed Bug 1590506 Opened 5 years ago Closed 5 years ago

The today pane's tomorrow and upcoming toggles can get stuck

Categories

(Calendar :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: pmorris, Assigned: pmorris)

Details

Attachments

(1 file)

In the today pane, after clicking forward and back through viewing a few different days, the toggle to open and close the "Tomorrow" and "Upcoming" sections can stop working. The little toggle arrow still changes direction, but the panel showing the events doesn't close. The "Today" toggle still works even when the others don't.

Attached patch today-pane-toggles-0.patch — — Splinter Review

An event listener wasn't being added back when the toggles re-appeared.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e9ccb032e0affc5536f7adb6e61069110609d60b

Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #9104248 - Flags: review?(geoff)
Attachment #9104248 - Flags: review?(geoff) → review+

Another beta candidate?

Flags: needinfo?(paul)
Target Milestone: --- → 72

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7e30a34a0d7f
Fix the today pane's tomorrow and upcoming toggles. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 9104248 [details] [diff] [review]
today-pane-toggles-0.patch

This is indeed needed on beta.  Adding approval for upload since Geoff is out this week.
Flags: needinfo?(paul)
Attachment #9104248 - Flags: approval-calendar-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: