Update mingw-clang build to clang 9
Categories
(Firefox Build System :: General: Unsupported Platforms, enhancement)
Tracking
(firefox73 fixed)
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
(This is for -central only, not to be backported to esr68)
To match the rest of our builds, we'd like to update to clang 9.
Bug 1548624 may still be valid, unsure.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Attached is a WIP patch. It fails like so:
In file included from Unified_cpp_gfx_graphite2_src0.cpp:2:
In file included from /builds/worker/workspace/build/src/gfx/graphite2/src/CmapCache.cpp:28:
In file included from /builds/worker/workspace/build/src/gfx/graphite2/src/inc/Main.h:29:
In file included from /builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers/cstdlib:44:
In file included from /builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/c++/v1/cstdlib:85:
In file included from /builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/c++/v1/stdlib.h:100:
In file included from /builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/c++/v1/math.h:311:
In file included from /builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers/type_traits:50:
In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:31:
In file included from /builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers/new:44:
In file included from /builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/c++/v1/new:90:
/builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/c++/v1/exception:180:5: error: no member named 'abort' in namespace 'std::__1'; did you mean simply 'abort'?
_VSTD::abort();
^~~~~~~
/builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/c++/v1/__config:793:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_ABI_NAMESPACE
^
/builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/stdlib.h:402:40: note: 'abort' declared here
void __cdecl __MINGW_ATTRIB_NORETURN abort(void);
^
1 error generated.
Here's what I think is happening.
gfx/graphite2/src/inc/Main.h asks for cstdlib which goes to our stl_wrappers/cstdlib (fine)
That pulls in the real cstdlib (fine)
The real cstdlib, on line 85, pulls in stdlib.h (fine)
Which pulls in math.h (fine)
Which pulls in type_traits (fine)
It gets our type_traits from stl_wrappers AND HERE'S WHERE IT GOES BAD.
Our type_traits pulls in the real type_traits (not pictured in stack) and THEN it pulls in mozalloc.h
mozalloc.h pulls in new which goes first to our stl_wrappers/new (fine) and then to the real new
The real new pulls in exception
exception references _VSTD::abort() which is undefined.
Why is it undefined? Because it's defined on line 129 of the real cstdlib. And we haven't reached that line yet. We went off the rails over on line 85 of the real cstdlib.
|
|
Assignee | |
Comment 3•3 years ago
|
||
08:21:38 <jacekc> tjr: if I read the code right, here is already a code that should prevent type_traits from including mozalloc.h
08:22:44 <jacekc> cstdlib will define MOZ_INCLUDE_MOZALLOC_H and type_traits will check if it's defined and if it is, it should not include it (and leave it for cstdlib to include it later)
08:23:02 <jacekc> so the question is why it doesn't work...
|
|
Assignee | |
Comment 4•3 years ago
|
||
Looked at this a little bit. From my preprocessor output and a diff between the windows type_traits and linux type_traints - I think we're using linux style. The moz.build likewise implies.
Sending in a try run making the mingw build create a windows-style stl_wrappers and see what that does: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9efc8aaafda3941c9820059e0a886cfaea5b6650
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 5•3 years ago
|
||
Turns out we were using the Linux ones. This uses the Windows ones, and
adds _HAS_EXCEPTIONS to the mingw defines so the stl_wrappers behave
correctly.
Depends on D50152
|
|
Assignee | |
Comment 6•3 years ago
|
||
We break them out of Unified builds and then correct a couple random unified
build errors.
Depends on D54530
|
|
Assignee | |
Comment 7•3 years ago
|
||
This is affected by the same problem detailed in the comment.
Depends on D54531
|
|
||
Updated•3 years ago
|
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d305e4160ee4 Update the mingw-clang compiler to clang 9 r=dmajor https://hg.mozilla.org/integration/autoland/rev/2b28154aacdb Use windows-style stl_wrappers for mingw build r=glandium https://hg.mozilla.org/integration/autoland/rev/8432398c212a mingw-clang cannot use _xgetbv without -mavx, work around it r=lsalzman,froydnj https://hg.mozilla.org/integration/autoland/rev/2ac8dd1d709d Define a __imp_ alias for _strdup for mingw-clang r=dmajor
|
||
Comment 9•3 years ago
|
||
Backed out for breaking gecko decision task
Push with failures https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=2ac8dd1d709d253a220f51de516465d1707ced65&selectedJob=280811077
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280811077&repo=autoland&lineNumber=495
Backout: https://hg.mozilla.org/integration/autoland/rev/bd27dfd96896dde5f30d6d3942072cf35fba7827
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 10•3 years ago
|
||
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02a71c2df35c Update the mingw-clang compiler to clang 9 r=dmajor https://hg.mozilla.org/integration/autoland/rev/79bf2b523d94 Use windows-style stl_wrappers for mingw build r=glandium https://hg.mozilla.org/integration/autoland/rev/df32eb1fdc8d mingw-clang cannot use _xgetbv without -mavx, work around it r=lsalzman,froydnj https://hg.mozilla.org/integration/autoland/rev/c2cffffd5ca6 Define a __imp_ alias for _strdup for mingw-clang r=dmajor
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/02a71c2df35c
https://hg.mozilla.org/mozilla-central/rev/79bf2b523d94
https://hg.mozilla.org/mozilla-central/rev/df32eb1fdc8d
https://hg.mozilla.org/mozilla-central/rev/c2cffffd5ca6
Description
•