1590643 - Be more consistent about arena_id_t argument order

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

The code here looks a bit inconsistent: https://searchfox.org/mozilla-central/rev/8a63fc190b39ed6951abb4aef4a56487a43962bc/js/src/vm/StringType.cpp#460-464

I think this is because the arena argument to cx->pod_malloc is optional. We could avoid this if we added cx->pod_arena_malloc instead. That also makes the name more consistent with js_pod_arena_malloc.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1590643 - Be more consistent about arena_id_t arguments in MallocProvider.h. r=jwalden!

Add separate pod_arena_* overloads and remove the optional arena_id_t arguments.

This makes both the naming and argument order more consistent with similar code
elsewhere (for example js_pod_arena_malloc, AllocPolicyBase::pod_arena_malloc).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53abc22d3299
Be more consistent about arena_id_t arguments in MallocProvider.h. r=jwalden

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/53abc22d3299