Closed Bug 1590678 Opened 9 months ago Closed 8 months ago

Remove -Wmaybe-uninitialized warning in tls13esni.c

Categories

(NSS :: Build, defect, P1)

3.47
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: giulio.benetti, Assigned: giulio.benetti)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.70 Safari/537.36

Steps to reproduce:

Build with -Os and -werror

Actual results:

ls13esni.c: In function ‘tls13_ServerDecryptEsniXtn’:
tls13esni.c:791:8: error: ‘suiteDef’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
rv = tls13_ComputeESNIKeys(ss, entry,
^

Assignee: nobody → giulio.benetti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
Comment on attachment 9103473 [details] [diff] [review]
0001-Bug-1590678-Remove-Wmaybe-uninitialized-warning-in-t.patch

Review of attachment 9103473 [details] [diff] [review]:
-----------------------------------------------------------------

Try push - https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=5390edc05376
Attachment #9103473 - Flags: review?(jjones) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 3.48
You need to log in before you can comment on or make changes to this bug.