Closed Bug 1590700 Opened 5 years ago Closed 4 years ago

Rename "Scripts" marker to something more descriptive

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: canova, Assigned: canova)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now we have "Scripts" markers that belongs to Graphics category. It's pretty hard to understand the purpose of that marker and current name is misleading. At first sight, I thought it was a marker that indicates the parsing/executing of a script. But we have "Script" marker for that(without an "s" at the end). That marker is inside nsRefreshDriver::RunFrameRequestCallbacks currently and I think it indicates the execution of requestAnimationFrame callbacks. We should rename it to something more descriptive and avoid the misleading names.

Benoit, you wrote this "only" 6 years ago in bug 918825, you may have suggestions? ;-)

Depends on: 918825
Flags: needinfo?(b56girard)

I suggest "requestAnimationFrame callbacks"

Flags: needinfo?(b56girard)

That would be my suggestion too.

"Scripts" wasn't making any sense for this marker and it was nearly imposssible
to understand. It should be "requestAnimationFrame callbacks" instead.

Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/494fd74c735f
Rename "Scripts" marker to "requestAnimationFrame callbacks". r=gerald
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: