1590706 - Add browsing context ID of current tab inside the profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

We need to store that information in the profiler for "single tab profiling". Currently we store page information of all the frames and we keep inner window IDs of frames inside the markers. We are working on adding that information inside JS frames as well in bug 1468789. After that we will be able to identify the relevant frames and markers for that tab. We should add that information inside the profiler so we can do the filtering.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1590706 - Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r?gerald

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1590706 - Part 2: Update devtools and popup panels to include BrowsingContext IDs. r?gregtatum

Depends on D54144

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c2af658ce76
Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r=gerald
https://hg.mozilla.org/integration/autoland/rev/c98daf6c7687
Part 2: Update devtools and popup panels to include BrowsingContext IDs. r=gregtatum

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets for causing bustages in gtest/GeckoProfiler.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/5939df43d66ee80779f2ebe633d3c98230fcd893

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&tochange=5939df43d66ee80779f2ebe633d3c98230fcd893&fromchange=c98daf6c76874cb616357fe2ccb05f99ac4fe35f&searchStr=build

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=278403337&repo=autoland&lineNumber=36786
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=278403290&repo=autoland&lineNumber=39292

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d738ecde312
Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r=gerald
https://hg.mozilla.org/integration/autoland/rev/59139e8c6636
Part 2: Update devtools and popup panels to include BrowsingContext IDs. r=gregtatum

Comment 6

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

There was a new test between my last rebase and m-c, rebased on top of it and fixed the test.

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/7d738ecde312
https://hg.mozilla.org/mozilla-central/rev/59139e8c6636