1590721 - The "IMPRESSION" ping for the "What's New" toolbar button is wrongly displayed in the "Browser Console" even if the "browser.messaging-system.whatsNewPanel.enabled" pref is set to "False"

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Release 70.0 and above

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have a new Firefox profile with the following prefs in the "about:config" page:
  • "browser.messaging-system.whatsNewPanel.enabled" pref set to "false"
  • "browser.ping-centre.log" set to "true"
• Have the "Browser Console" opened.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Focus the "Browser Console" and wait ~5 minutes.
3. Observe the telemetry pings displayed in the "Browser Console".

[Expected result]:

• There are no "WHATS_NEW_BADGE_70" telemetry pings displayed.

[Actual result]:

• The following ping is displayed, even if the "What's New" toolbar button is not:
  "TELEMETRY PING: {"locale":"en-US","topic":"activity-stream-router","client_id":"n/a","version":"70.0","release_channel":"release","addon_version":"20191016161957","impression_id":"{d08454c1-6a87-424c-8436-588bbc35009a}","action":"cfr_user_event","source":"CFR","message_id":"WHATS_NEW_BADGE_70","event":"IMPRESSION","shield_id":"activity-stream-extended-triplets-v2-1581912:control;","profile_creation_date":18192,"region":"RO"}"

[Notes]:

• Attached a screen recording of the issue:

Comment 1

[Ed Lee :Mardak]

andreio, is this the impression from trying to show the badge (but the icon doesn't exist) ?

https://github.com/mozilla/activity-stream/blob/9567f8963cf77c3b33616b902215de933c15c5b8/lib/ToolbarBadgeHub.jsm#L274-L284

Comment 2

[Andrei Oprea [:andreio]]

Yes the badge doesn't wait to see if setting up the button was successful.

Comment 3

[Kate Hudson :k88hudson]

Based on :felix's assessment that this will not negatively affect data analysis, we do not consider this a blocking bug for the experiment, however we will address it in 72+.

Comment 4

[Andrei Oprea [:andreio]]

Attachment: Bug 1590721 - Send impression pings only when adding a toolbar badge

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6697a20a06d2
Send impression pings only when adding a toolbar badge r=k88hudson

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6697a20a06d2

Comment 7

[Robert Martin [:romartin], Ecosystem QA]

I have verified that this issue is no longer reproducible using Latest Nightly build (72.0a1 Build ID: 20191120234543) on Windows 10 x64, Mac OS 10.15 and Ubuntu 18.04 x64. The "IMPRESSION" ping for the "What's New" toolbar button is no longer being displayed in "Browser Console" if the "browser.messaging-system.whatsNewPanel.enabled" pref is set to "False".