1590749 - Make it easier to trigger the milestone doorhanger for testing

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

In particular, the 24h update interval is pretty hard to overcome.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1590749 - Make the update interval for the milestone doorhanger configurable. r=ewright

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f162d032993
Make the update interval for the milestone doorhanger configurable. r=ewright

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0f162d032993

Comment 4

[Erica Wright [:ewright]]

Johann, do you think we can uplift this so QA can use it for testing on 71?

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 9103545 [details]
Bug 1590749 - Make the update interval for the milestone doorhanger configurable. r=ewright

Beta/Release Uplift Approval Request

• User impact if declined: This patch is adding a flag to make it possible for QA to test the new tracking milestone feature.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a very simple change that only adds a pref to configure a previously hard-coded value (the refresh rate of the milestone achievements)
• String changes made/needed: None

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9103545 [details]
Bug 1590749 - Make the update interval for the milestone doorhanger configurable. r=ewright

Low risk patch that will make QA easier in 71, uplift approved for 71 beta 5, thanks!

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f2bbdda539c1