Closed Bug 1590766 Opened 1 year ago Closed 9 months ago

Supported nested workers debugging

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox74 fixed)

RESOLVED FIXED
Firefox 74
Tracking Status
firefox74 --- fixed

People

(Reporter: Harald, Assigned: bhackett1024)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

What were you doing?

  1. Open Debugger on https://firefox-devtools-nested-workers.glitch.me/

What happened?

Only worker.js is visible in Threads.
Only worker.js is visible as scope in Sources

What should have happened?

See both worker.js (named Base) and nested-worker.js (named Nested).

Summary: Supported nested workers → Supported nested workers debugging
Blocks: dbg-72

The problem here is that workers created by other workers always have a null nsIWorkerDebugger.window property, even when their transitive parent is associated with some window. When debugging a browsing context, the WorkerTargetActorList uses the window to see if the worker is associated with its target window, so the inner worker will be filtered out. (When using the OBT this filtering does not happen and the inner worker will be visible.)

I don't see why nsIWorkerDebugger.window should return null for inner workers (there aren't any comments anywhere), so this patch changes it to return the window associated with its transitive parent, allowing the WorkerTargetActorList filtering to work correctly.

Assignee: nobody → bhackett1024
Status: NEW → ASSIGNED
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18a70a2e11c3
Use transitive parent's window in nsIWorkerDebugger.window, r=asuth.
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.