1590766 - Supported nested workers debugging

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[:Harald Kirschner :digitarald]

What were you doing?

1. Open Debugger on https://firefox-devtools-nested-workers.glitch.me/

What happened?

Only worker.js is visible in Threads.
Only worker.js is visible as scope in Sources

What should have happened?

See both worker.js (named Base) and nested-worker.js (named Nested).

Comment 1

[Brian Hackett [Laid off!]]

The problem here is that workers created by other workers always have a null nsIWorkerDebugger.window property, even when their transitive parent is associated with some window. When debugging a browsing context, the WorkerTargetActorList uses the window to see if the worker is associated with its target window, so the inner worker will be filtered out. (When using the OBT this filtering does not happen and the inner worker will be visible.)

I don't see why nsIWorkerDebugger.window should return null for inner workers (there aren't any comments anywhere), so this patch changes it to return the window associated with its transitive parent, allowing the WorkerTargetActorList filtering to work correctly.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1590766 - Use transitive parent's window in nsIWorkerDebugger.window, r=asuth.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18a70a2e11c3
Use transitive parent's window in nsIWorkerDebugger.window, r=asuth.

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/18a70a2e11c3