1590813 - Prioritize loading of source-maps for opened tabs

Status: NEW

(DevTools :: Debugger, defect, P3)

Description

[Sorin Davidoi]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

• Load https://riot.im/app/ (no need for an account)
• Open developer tools
• Open https://riot.im/app/bundles/2399aff5932e52cc7d90/node_modules/matrix-react-sdk/lib/Avatar.js in the debugger
• Close developer tools
• Open developer tools

Actual results:

Debugger view was empty for 7.2 seconds (after which time the tab for Avatar.js appears).

Expected results:

The tab for Avatar.js should have appeared sooner.

Comment 1

[Sorin Davidoi]

Attachment: perf(newSources): Process sources that are opened first

Process sources that are visible first

The following profiles were taken while following the last step from the reproduction instructions. You can observe from the screenshots that the tab was opened 1.5 seconds earlier.

Before: https://perfht.ml/2MGTn5t
After: https://perfht.ml/32KJedq

Comment 2

[Patrick Brosset <:pbro>]

Hi Sorin, just checking in, are you still interested in working on this fix? Jason had pushed to try back in November and it looked like a couple tests were failing then: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e0fed8dbb7d9e93b526b8b537f84ba84344444f
Please let us know if you intend to continue working on this or not.

Comment 3

[Sorin Davidoi]

Hi Patrick, I'll try to pick this up again soon.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hi Sorin, are you still planning to pick up this bug? Do you need any help?

Honza

Comment 5

[Sorin Davidoi]

Hi Honza, I don't think I'll pick it up. Feel free to close it.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the update Sorin!

Logan, could we look at this bug as part of you work on Source Maps / Sources?

Honza

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Sorin, can you still reproduce the problem?
Are the STR still valid?

Honza

Comment 8

[Logan Smyth [:loganfsmyth]]

I'll keep this on my radar as something to look into when exploring sources. The motivation behind this issue seems good, but I'd want to explore if there are alternatives that would let us avoid the explicit checks against the visible tabs.

Comment 9

[Sorin Davidoi]

Still valid, as are the STR.