1590827 - Add remote-agent-requested system notification

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

The remote agent currently waits for the sessionstore-windows-restored
event, but we should reverse the model so that application code can
decide when it is safe to start the remote agent.

This is similar to the model used for Marionette, which listens for
marionette-startup-requested. We could probably rely on exactly
this event at the moment, but in the interest of decoupling Marionette
from the remote agent we should probably have a separate notification
for the remote agent.

Comment 1

[Andreas Tolfsen ❲:ato❳]

The remote agent startup code changes as part of bug 1543115
which means it is a short-term blocker for addressing this.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1590827: remote, browser: request remote agent startup;

This moves the Chromium remote debugging protocol implementation
in Firefox from using sessionstore-windows-restored to a new
remote-startup-requested notification observer.

This change makes it possible for applications to explicitly decide
at which stage it is considered safe to initialise the remote agent
listener. It is safe to emit this notification at any time since
the observer for it is only registered after the --remote-debugger
flag is is used.

The remote debugger only supports Firefox, so this patch does not
take care of GeckoView/Android.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e260a401d107
remote, browser: request remote agent startup; r=florian,remote-protocol-reviewers,maja_zf

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e260a401d107