1590845 - Add JS::MemoryUse values for embedders

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Philip Chimento [:ptomato]]

The current values in the JS::MemoryUse enum don't necessarily fit the usages that embedders might have for their C-allocated memory. In order to make JS::AddAssociatedMemory() and JS::RemoveAssociatedMemory() more useful for embedders I'd propose adding JS::MemoryUse::Embedding1 through JS::MemoryUse::Embedding5 to the public JS::MemoryUse enum.

Comment 1

[Philip Chimento [:ptomato]]

Attachment: Bug 1590845 - Add JS::MemoryUse::Embedding1 through 5. r?tcampbell

This makes JS::AddAssociatedMemory() and JS::RemoveAssociatedMemory()
more useful for embedders.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4f991bcd898
Add JS::MemoryUse::Embedding1 through 5. r=tcampbell,jonco

Comment 3

[Philip Chimento [:ptomato]]

Comment on attachment 9103724 [details]
Bug 1590845 - Add JS::MemoryUse::Embedding1 through 5. r?tcampbell

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This makes the JS::AddAssociatedMemory and JS::RemoveAssociatedMemory APIs more useful for SpiderMonkey embedders, who primarily use the ESR version.
• User impact if declined: SpiderMonkey embedders will have less accurate memory tracking in their applications
• Fix Landed on Version: 72
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds some more values to an enum, which are not used within Firefox, so it seems quite low-risk.
• String or UUID changes made by this patch: None

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e4f991bcd898

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9103724 [details]
Bug 1590845 - Add JS::MemoryUse::Embedding1 through 5. r?tcampbell

This needs a rebased patch for ESR68.

Comment 6

[Philip Chimento [:ptomato]]

Attachment: Backport of patch to ESR68

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: I've added a backport of the patch to ESR68. For rationale please see earlier uplift request on this bug.
• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String or UUID changes made by this patch:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9105470 [details] [diff] [review]
Backport of patch to ESR68

SM embedding improvements. NPOTB for Firefox. Approved for 68.3esr.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/fdf55403f16c