Closed Bug 1590889 Opened 5 years ago Closed 5 years ago

NS_ENSURE_SUCCESS spam in debug builds.

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mossop, Assigned: mossop)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [domsecurity-active])

Attachments

(1 file)

This NS_ENSURE_SUCCESS logs an awful lot of failures during debug builds: https://searchfox.org/mozilla-central/rev/088e2cf29c59d733d57af43903eb0267dbf72e2a/dom/base/ThirdPartyUtil.cpp#217

Are failures of that test expected? If so this should not be using NS_ENSURE_SUCCESS for its check.

Flags: needinfo?(sstreich)
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/880dd7fed087
Stop warning on common failures in ThirdPartyUtil.cpp r=ckerschb

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Flags: needinfo?(sstreich)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: