1590972 - Use -std=c99 rather than -std=gnu99

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Martin Thomson [:mt:]]

This introduces fewer weird definitions into the build.

However, this also requires that we define _DEFAULT_SOURCE because we rely on many functions that are enabled by that.

Comment 1

[Martin Thomson [:mt:]]

Attachment: Bug 1590972 - Use -std=c99 for all C code, r?jcj

Comment 2

[Martin Thomson [:mt:]]

After investigating this more (thanks to glandium too), I'll have to add _BSD_SOURCE to cover back to glibc 2.12.

• the conversions from <endian.h>, which are used by HACL*, htole64, be64toh, le32toh, and htole32.
• realpath is used in one place
• strdup appears in a few places

The interesting one is getentropy, which is only conditioned on _DEFAULT_SOURCE. As we already test the GLIBC version in that code, we're OK.

gcc 4.4 turned up an interesting problem that I need to look into:

In file included from rijndael.c:16:
rijndael.h:71: warning: declaration does not declare anything
rijndael.c: In function ‘rijndael_key_expansion7’:
rijndael.c:333: error: ‘AESContext’ has no member named ‘expandedKey’

I think that the best plan there is to name the struct.

Comment 3

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/dbba7db4b79d43ff5e2e655f7a978eb5e43d6458