1591007 - "Save Changes" in "Manage Data" dialog in preferences doesn't close the dialog

Status: RESOLVED FIXED

(Firefox :: Preferences, defect, P3)

Description

[red-fox0]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

1. about:preferences#privacy
2. click "Manage Data…" in section "Cookies and Site Data".
3. do nothing and delete nothing (!)
4. click "Save Change"

Actual results:

Widget did not close.

Expected results:

Closed widget

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[YF (Yang)]

Not a regression.

Comment 3

[:Gijs (he/him)]

Johann, what is this /supposed/ to do?

Comment 4

[Johann Hofmann [:johannh]]

Huh, good question, I would say it should close. Seems like a good mentored bug. Not aware of any dupes, but maybe I'm wrong.

Comment 5

[Jacob Stenson]

Hi there, I would like to take on this bug. I am new to debugging mozilla code and also new to bugzilla so I may need some guidance completing it if that is okay. Could you give me an idea as to which file I would need to edit to fix this bug? Thanks

Comment 6

[:Gijs (he/him)]

(In reply to Jacob Stenson from comment #5)

Hi there, I would like to take on this bug. I am new to debugging mozilla code and also new to bugzilla so I may need some guidance completing it if that is okay. Could you give me an idea as to which file I would need to edit to fix this bug? Thanks

Best needinfo the mentor rather than the reporter. It so happens Johann is out, so I'll step in for the moment.

In https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/browser/components/preferences/siteDataSettings.js#265-291, allowed starts out as false and is never set to true if there are no items to remove. Does that help?

Comment 7

[red-fox0]

if (removals.length) {
    //…
} else {
    //nothing
    allowed = true; 
}

Right?

Comment 8

[Jacob Stenson]

Thank you for stepping in for Johann. Yes that appears to help. I will start work on fixing this and get back to you. Thanks a lot.

Comment 9

[Jacob Stenson]

I believed I have solved the issue. Heading to about:preferences#privacy then going to "Manage Data…" in the "Cookies and Site Data" section. After changing no settings I click "Save Changes" and the widget closes.
What are the next steps for me to get this code commited, reviewed and completed? Sorry to ask for help on every step, I am very new to this. I appreciate the help.

Comment 10

[Jacob Stenson]

Attachment: Bug 1591007 - Save Changes in Manage Data dialog in preferences doesn't close the dialog, r=Gijs

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2eaeb35d81d6
Save Changes in Manage Data dialog in preferences doesn't close the dialog, r=Gijs

Comment 12

[:Gijs (he/him)]

Looks like you figured it out - thanks!

Comment 13

[Jacob Stenson]

Thank you. Do I need to do anything else?

Comment 14

[:Gijs (he/him)]

(In reply to Jacob Stenson from comment #13)

Thank you. Do I need to do anything else?

Nope. The bug will get closed automatically once the change is merged to mozilla-central, so leaving it open for now.

Comment 15

[Jacob Stenson]

Ah okay, apologies for closing it prematurely.

Comment 16

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2eaeb35d81d6