1591087 - Add some more HTML*Element sizeof assertions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Gecko has some more elements which have the same size as div and span. We could assert the sizeof at least some of the common ones to prevent accidental regressions.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1591087 - Add some more HTML*Element sizeof assertions, r=ehsan

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f7e0a75c86fa3a3919f80333994827c42600370

Comment 3

[(no longer active)]

Out of curiosity, how did you find these elements?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5458333aaa26
Add some more HTML*Element sizeof assertions, r=Ehsan

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

find? I was just looking at some element implementations and thought which ones might be common.
Unfortunately I don't have data about which are the most common ones.
There is https://raw.githack.com/operasoftware/devopera-static-backup/master/http/dev.opera.com/articles/view/mama-basic-document-structure/index.html#elems but that doesn't answer to the question I want.

I'd like to add static_asserts for other cases too, but still in process trying to find which elements are really the most common ones.
We probably don't need to care too much about rarely used elements.

input element, which is massive, has its own assert
https://searchfox.org/mozilla-central/rev/2a355e56c490768be676689de18629485c9d699b/dom/html/HTMLInputElement.cpp#997-1000

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5458333aaa26