1591114 - dom/tests/mochitest/bugs/test_bug260264.html should await SpecialPowers.testPermission

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Rob Wu [:robwu]]

https://searchfox.org/mozilla-central/rev/088e2cf29c59d733d57af43903eb0267dbf72e2a/dom/tests/mochitest/bugs/test_bug260264.html#36,41 uses SpecialPowers.testPermission as follows:

ok(SpecialPowers.testPermission('popup', UNKNOWN_ACTION, document), 'popup value should have UNKNOWN permission');

Starting from bug 1541557, this method returns a promise, so the check is incorrect. It needs to have await in front of the SpecialPowers.testPermission call in order to be meaningful. Without it, the test always passes, even if it should not be, because a Promise is truthy.

In bug 1587801, the test was refactored. Because of this bug, it is not clear whether the sanity check actually checks sanity. I'll fix the check.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1591114 - test_bug260264.html should await SpecialPowers.testPermission

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c46d79d9d4ae
test_bug260264.html should await SpecialPowers.testPermission r=smaug

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c46d79d9d4ae

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6c0dbccdc5e8