1591191 - Move Compare method to work on substrings

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Based on https://phabricator.services.mozilla.com/D49668

Compare method currently only works on String, but it should cover Substring as well.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1591191 - Move compare and EqualsIgnoreAsciiCase to nsTStringRepr.

Zibi is working on replacing some string based APIs with some things that return
substrings, so we could use this.

Alternatively he'd have to do something like:

Compare(myCSubstring, nsDependentCSubstring(aTag, strlen(aTag)))

or something of that sort, which looks a bit uglier.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb3d67637a9b
Move compare and EqualsIgnoreAsciiCase to nsTStringRepr. r=erahm

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset eb3d67637a9b (bug 1591191) for build bustage on build/src/xpcom/string/precompiled_templates.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274351487&repo=autoland&lineNumber=14326

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=eb3d67637a9bbaaf8507c9748785c627bd33e723

Backout:
https://hg.mozilla.org/integration/autoland/rev/2457ce6fec56104d5dea5a32a55a670ab731b30a

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa1628003bf9
Move compare and EqualsIgnoreAsciiCase to nsTStringRepr. r=erahm

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/fa1628003bf9