1591226 - Convert the prefs in ReferrerInfo.cpp to static prefs

Status: RESOLVED FIXED

(Core :: Preferences: Backend, task)

Description

[Kris Wright :KrisWright]

There are 11 prefs in ReferrerInfo.cpp that need to be converted to static prefs. Three of these prefs need to leverage the "do_not_use_directly" field and a getter, since their original mirror variables are clamped.

Comment 1

[Kris Wright :KrisWright]

Attachment: Bug 1591226 - Convert network.http.referer.spoofSource to static pref.

Converts network.http.referer.spoofSource to a static pref and removes the varcache instance and mirror variable.

Comment 2

[Kris Wright :KrisWright]

Attachment: Bug 1591226 - Convert network.http.referer.hideOnionSource to a static pref.

Converts network.http.referer.hideOnionSource to a static pref and removes its mirror variable and varcache pref definition.

Comment 3

[Kris Wright :KrisWright]

Attachment: Bug 1591226 - Convert network.http.sendRefererHeader to a static pref.

Converts network.http.sendRefererHeader to a static pref. The original mirror variable was clamped between 0 and 2, so the pref has been updated with DoNotUseDirectly and a getter.

Comment 4

[Kris Wright :KrisWright]

Attachment: Bug 1591226 - Convert network.http.referer.referrerLengthLimit to static pref.

Converts network.http.referer.referrerLengthLimit to a static pref and replaces its mirror variable.

Comment 5

[Kris Wright :KrisWright]

Attachment: Bug 1591226 - Convert network.http.referer.XOriginPolicy to static pref.

Converts network.http.referer.XOriginPolicy to a static pref and leverages 'do_not_use_directly' and a getter in order to clamp the value.

Comment 6

[Kris Wright :KrisWright]

Attachment: Bug 1591226 - Convert network.http.referer.trimmingPolicy to static pref.

Converts network.http.referer.trimmingPolicy and leverages do_not_use_directly with a getter to clamp the value.

Comment 7

[Kris Wright :KrisWright]

Attachment: Bug 1591226 - Convert network.http.referer.XOriginTrimmingPolicy to static pref.

Converts network.http.referer.XOriginTrimmingPolicy to a static pref. Leverages do_not_use_directly and a getter to clamp the pref value.

Comment 8

[Kris Wright :KrisWright]

Attachment: Bug 1591226 - Convert network.http.referer.defaultPolicy.* to static prefs

Converts network.http.referer.defaultPolicy, network.http.referer.defaultPolicy.trackers, network.http.referer.defaultPolicy.pbmode, and network.http.referer.defaultPolicy.trackers.pbmode to static prefs and updates the uses of their old mirror values.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2efb727423dd
Convert network.http.referer.spoofSource to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/0c488c215ac2
Convert network.http.referer.hideOnionSource to a static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/b0aea55adfc3
Convert network.http.sendRefererHeader to a static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/05a6a47f9540
Convert network.http.referer.referrerLengthLimit to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/cfc175e24f4e
Convert network.http.referer.XOriginPolicy to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/e8fc2920b08c
Convert network.http.referer.trimmingPolicy to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/079eaf8c45e5
Convert network.http.referer.XOriginTrimmingPolicy to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/869a61c656cd
Convert network.http.referer.defaultPolicy.* to static prefs r=njn

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2efb727423dd
https://hg.mozilla.org/mozilla-central/rev/0c488c215ac2
https://hg.mozilla.org/mozilla-central/rev/b0aea55adfc3
https://hg.mozilla.org/mozilla-central/rev/05a6a47f9540
https://hg.mozilla.org/mozilla-central/rev/cfc175e24f4e
https://hg.mozilla.org/mozilla-central/rev/e8fc2920b08c
https://hg.mozilla.org/mozilla-central/rev/079eaf8c45e5
https://hg.mozilla.org/mozilla-central/rev/869a61c656cd