Closed Bug 1591226 Opened 3 months ago Closed 3 months ago

Convert the prefs in ReferrerInfo.cpp to static prefs

Categories

(Core :: Preferences: Backend, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: KrisWright, Assigned: KrisWright)

References

(Blocks 1 open bug)

Details

Attachments

(8 files)

There are 11 prefs in ReferrerInfo.cpp that need to be converted to static prefs. Three of these prefs need to leverage the "do_not_use_directly" field and a getter, since their original mirror variables are clamped.

Converts network.http.referer.spoofSource to a static pref and removes the varcache instance and mirror variable.

Converts network.http.referer.hideOnionSource to a static pref and removes its mirror variable and varcache pref definition.

Converts network.http.sendRefererHeader to a static pref. The original mirror variable was clamped between 0 and 2, so the pref has been updated with DoNotUseDirectly and a getter.

Converts network.http.referer.referrerLengthLimit to a static pref and replaces its mirror variable.

Converts network.http.referer.XOriginPolicy to a static pref and leverages 'do_not_use_directly' and a getter in order to clamp the value.

Converts network.http.referer.trimmingPolicy and leverages do_not_use_directly with a getter to clamp the value.

Converts network.http.referer.XOriginTrimmingPolicy to a static pref. Leverages do_not_use_directly and a getter to clamp the pref value.

Converts network.http.referer.defaultPolicy, network.http.referer.defaultPolicy.trackers, network.http.referer.defaultPolicy.pbmode, and network.http.referer.defaultPolicy.trackers.pbmode to static prefs and updates the uses of their old mirror values.

Pushed by kwright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2efb727423dd
Convert network.http.referer.spoofSource to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/0c488c215ac2
Convert network.http.referer.hideOnionSource to a static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/b0aea55adfc3
Convert network.http.sendRefererHeader to a static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/05a6a47f9540
Convert network.http.referer.referrerLengthLimit to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/cfc175e24f4e
Convert network.http.referer.XOriginPolicy to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/e8fc2920b08c
Convert network.http.referer.trimmingPolicy to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/079eaf8c45e5
Convert network.http.referer.XOriginTrimmingPolicy to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/869a61c656cd
Convert network.http.referer.defaultPolicy.* to static prefs r=njn
Assignee: nobody → kwright
You need to log in before you can comment on or make changes to this bug.