Closed Bug 1591254 Opened 5 years ago Closed 5 years ago

set WorkletNodeEngine::ProcessBlocksOnPorts() input and output span lengths appropriately for zero inputs and outputs

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox-esr68 --- disabled
firefox69 --- disabled
firefox70 --- disabled
firefox71 --- disabled
firefox72 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(1 file)

Bug 1591254 set WorkletNodeEngine input and output span lengths appropriately for zero inputs and outputs r?padenot
47 bytes, text/x-phabricator-request
Details | Review

AudioNodeTrack::ProcessInput() uses ProcessBlock() when input and output counts are <= 1, but WorkletNodeEngine::ProcessBlock() assumes counts == 1.

This bug was detected by webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-automatic-pull.https.html with some changes for bug 1565956.

Flags: in-testsuite+

AudioNodeTrack::ProcessInput() uses ProcessBlock() when input and output
counts are <= 1.

Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18202ef8a94a
set WorkletNodeEngine input and output span lengths appropriately for zero inputs and outputs r=padenot

https://hg.mozilla.org/mozilla-central/rev/18202ef8a94a

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: