1591259 - BrowserGlue.jsm triggeres console log of Unhandled NS_ERROR_NOT_AVAILABLE (0x80040111, 2147746065) exception thrown from PushService lazy getter during "sessionstore-windows-restored" observer notification when dom.push.enabled == false

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[richard (Tor Project)]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Launch stock firefox ESR68 with the preference dom.push.enabled=false

Actual results:

Following error appears in debug console:
uncaught exception: 2147746065 SessionStore.jsm:1325:22

Comment 1

[richard (Tor Project)]

The issue does not appear to be present in latest Firefox 70. We have a bug tracking this issue here: https://trac.torproject.org/projects/tor/ticket/31573

Comment 2

[richard (Tor Project)]

(In reply to Richard Pospesel (Tor Browser Dev) from comment #1)

The issue does not appear to be present in latest Firefox 70. We have a bug tracking this issue here: https://trac.torproject.org/projects/tor/ticket/31573

This appears to have been fixed in commit 6a0111db7ba5a1a92f3eb68b89cb415bd08a4f3e

Comment 3

[richard (Tor Project)]

(In reply to Richard Pospesel (Tor Browser Dev) from comment #2)

(In reply to Richard Pospesel (Tor Browser Dev) from comment #1)

The issue does not appear to be present in latest Firefox 70. We have a bug tracking this issue here: https://trac.torproject.org/projects/tor/ticket/31573

This appears to have been fixed in commit 6a0111db7ba5a1a92f3eb68b89cb415bd08a4f3e

With a followup fix in 192e75e65bb32ce824c332992135aa7e9d6f246d

Comment 4

[richard (Tor Project)]

Act

Comment 5

[richard (Tor Project)]

Actually, after backporting the two fixes I'm still seeing this issue, and I can confirm this does actually happen in stock Firefox 70 as well (if you actually have dom.push.enabled=false)

Comment 6

[Seba S.]

Hi, Richard!

Thanks for your contribution!

There is an enhancement opened on this matter which you could check here https://bugzilla.mozilla.org/show_bug.cgi?id=1369436.

So far I couldn´t reproduce it, I am not receiving the mentioned error but please, check if the enhancement is correctly related to what you are talking about.

I'll add a product and component too. Apparently this was closed a month ago but I was following the entire thread and I assume is the same issue as you mention.

Please, feel free to add any comments or information if needed.

Regards,

Comment 7

[richard (Tor Project)]

Hi Seba,

Yeah, I initially tried applying the changes (6a0111db7ba5a1a92f3eb68b89cb415bd08a4f3e and 192e75e65bb32ce824c332992135aa7e9d6f246d in gecko-dev) from #1369436 but the issue remains. The fundamental problem is that the lazyGetter for PushService throws 2147746065 (NS_ERROR_NOT_AVAILABLE) if the dom.push.enabled preference is set to false (I had not correctly diagnosed the problem when I first claimed it did not occur in latest Firefox; you have to toggle the pref to false for it to occur). This issue sill occurs in latest which is unsurprising given that there's no checking before attempting to access PushService.

We could just catch and swallow the exception where it's currently happening, but I don't know what the effects of doing so in the rest of the system may be.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

It looks like this is coming from BrowserGlue.jsm in this chain of events:

• observer notification received: https://searchfox.org/mozilla-central/rev/3300072e993ae05d50d5c63d815260367eaf9179/browser/components/BrowserGlue.jsm#865
• calls _onWindowsRestored: https://searchfox.org/mozilla-central/rev/3300072e993ae05d50d5c63d815260367eaf9179/browser/components/BrowserGlue.jsm#1984
• calls Services.tm.idleDispatchToMainThread() of a lambda that calls PushService.wrappedJSObject.ensureReady() at https://searchfox.org/mozilla-central/rev/3300072e993ae05d50d5c63d815260367eaf9179/browser/components/BrowserGlue.jsm#2049

Since it's in a lambda, it doesn't actually break anything, but the error is annoying.

Moving to Firefox :: General which is what searchfox thinks BrowserGlue.jsm belongs to per in-tree mappings.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Hey emalysz, this might be related to your work in bug 1584014. Do you have some cycles to help Richard figure out a way forward here?

Comment 10

[Emma Malysz]

Attachment: Bug 1591259, insert catch block before accessing PushService to avoid exception during session-windows-restored

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da87ab43340f
insert catch block before accessing PushService to avoid exception during session-windows-restored r=mconley

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/da87ab43340f

Comment 13

[Ardelean Oana, Desktop QA [:oardelean]]

Reproduced with a 2019-11-05 Nightly build on macOS 12. Verified as fixed on Firefox 107.0(build ID: 20221107173030) and Nightly 108.0a1(build ID: 20221109164728) on macOS 12, Windows 10, Ubuntu 22.