Closed Bug 1591338 Opened 3 years ago Closed 3 years ago

Add an API to call an object's finalizer

Categories

(Core :: JavaScript: GC, enhancement, P1)

Product:
Core
Component:
JavaScript: GC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Bug 1591338 - Add a JS API to call a object's finalizer r?mccr8 r=jandem
47 bytes, text/x-phabricator-request
Details | Review

Object finalizers get called directly during cleanup of nursery-allocated wrapper cache wrappers. We should add a proper API for this and add some assertions around it. Found while looking at bug 1584796.

This replaces a direct call of an object'ss finalizer with a more formal API. This adds some assertions and passes a valid FreeOp pointer to the finalizer rather than null.

Attachment #9104149 - Attachment description: Bug 1591338 - Add a JS API to call a object's finalizer r?jandem,mccr8 → Bug 1591338 - Add a JS API to call a object's finalizer r=jandem r?mccr8
Attachment #9104149 - Attachment description: Bug 1591338 - Add a JS API to call a object's finalizer r=jandem r?mccr8 → Bug 1591338 - Add a JS API to call a object's finalizer r?mccr8 r=jandem
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cabe240bda92
Add a JS API to call a object's finalizer r=mccr8

https://hg.mozilla.org/mozilla-central/rev/cabe240bda92

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.