1591447 - Give browser_bug1058164.js a copy of BrowserTestUtils.addContentEventListener()

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Bug 1586393 will change BrowserTestUtils.addContentEventListener() to not use the message manager to listen for events, but browser_bug1058164.js is specifically interested in testing if frame scripts get certain messages. Thus to ensure that the test still does what it does, I'll first give the test its own copy of the message manager based addContentEventListener().

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1591447, part 1 - Copy over and use BrowserTestUtils.addContentEventListener() in browser_bug1058164.

browser_bug1058164 wants to test the behavior of event handling for
frame scripts using BrowserTestUtils.addContentEventListener(). In bug
1586393, I'm changing addContentEventListener() to not use frame
scripts, so this test will no longer be testing that. To work around
that, I'm making a copy of that method specific to the test.

Comment 2

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1591447, part 2 - Remove some addContentEventListener arguments in browser_bug1058164.js that aren't needed.

browser_bug1058164.js doesn't need the full generality, so trim it
down a bit.

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1591447, part 3 - Fix some name shadowing.

Eslint complains about this, so fix it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49160d42e538
part 1 - Copy over and use BrowserTestUtils.addContentEventListener() in browser_bug1058164. r=mconley
https://hg.mozilla.org/integration/autoland/rev/95c627a860ac
part 2 - Remove some addContentEventListener arguments in browser_bug1058164.js that aren't needed. r=mconley
https://hg.mozilla.org/integration/autoland/rev/ee8f4b063c89
part 3 - Fix some name shadowing. r=mconley

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/49160d42e538
https://hg.mozilla.org/mozilla-central/rev/95c627a860ac
https://hg.mozilla.org/mozilla-central/rev/ee8f4b063c89