1591488 - Opaque region for maximized windows is misshaped

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Alexander Steffens [:heftig]]

A maximized window still has a strip of transparency at the top and the left.

You can test this with gfx.webrender.debug.show-overdraw, which makes WebRender draw lots of nearly-transparent rectangles instead of actual content. The opaque regions of the window have a black background.

This seems to be because the region is offset for the CSD border, which does not exist on maximized windows.

Nightly, WebRender, GNOME 3.34.1, Arch Linux.

Comment 1

[Jan Alexander Steffens [:heftig]]

Attachment: Bug 1591488 - [Wayland] Only offset the opaque region for normal windows; r=stransky

Maximized and fullscreened windows do not have a CSD decoration border.

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Jan, do you mind to check the patch in?

Comment 3

[Jan Alexander Steffens [:heftig]]

(In reply to Martin Stránský [:stransky] from comment #2)

Jan, do you mind to check the patch in?

I'm not sure I'm allowed to do that. I only have Level 1 commit access. The checkin-needed keyword doesn't seem to work anymore, either.

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

(In reply to Jan Alexander Steffens [:heftig] from comment #3)

(In reply to Martin Stránský [:stransky] from comment #2)

Jan, do you mind to check the patch in?

I'm not sure I'm allowed to do that. I only have Level 1 commit access. The checkin-needed keyword doesn't seem to work anymore, either.

It was moved to phabricator. Go to phabricator revision, set "Edit revision" and add checkin needed at Tags.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ce8f56fb4f6
[Wayland] Only offset the opaque region for normal windows; r=stransky

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0ce8f56fb4f6