Closed Bug 1591488 Opened 8 months ago Closed 8 months ago

Opaque region for maximized windows is misshaped

Categories

(Core :: Widget: Gtk, defect)

Desktop
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: heftig, Assigned: heftig)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

A maximized window still has a strip of transparency at the top and the left.

You can test this with gfx.webrender.debug.show-overdraw, which makes WebRender draw lots of nearly-transparent rectangles instead of actual content. The opaque regions of the window have a black background.

This seems to be because the region is offset for the CSD border, which does not exist on maximized windows.

Nightly, WebRender, GNOME 3.34.1, Arch Linux.

Maximized and fullscreened windows do not have a CSD decoration border.

Assignee: nobody → jan.steffens
Status: NEW → ASSIGNED

Jan, do you mind to check the patch in?

Flags: needinfo?(jan.steffens)

(In reply to Martin Stránský [:stransky] from comment #2)

Jan, do you mind to check the patch in?

I'm not sure I'm allowed to do that. I only have Level 1 commit access. The checkin-needed keyword doesn't seem to work anymore, either.

Flags: needinfo?(jan.steffens)

(In reply to Jan Alexander Steffens [:heftig] from comment #3)

(In reply to Martin Stránský [:stransky] from comment #2)

Jan, do you mind to check the patch in?

I'm not sure I'm allowed to do that. I only have Level 1 commit access. The checkin-needed keyword doesn't seem to work anymore, either.

It was moved to phabricator. Go to phabricator revision, set "Edit revision" and add checkin needed at Tags.

Blocks: 1591489
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ce8f56fb4f6
[Wayland] Only offset the opaque region for normal windows; r=stransky
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Flags: qe-verify+
QA Whiteboard: [qa-72b-p2]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.