1591514 - Improve support for literals on FakeString

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task, P1)

Description

[Boris Zbarsky [:bzbarsky]]

We could flag ourselves with DataFlags::Literal when we know we have a literal. And we can make the bindings code nicer in the process too. For example, this:

    static const char16_t data[] = { 0 };
    mName.Rebind(data, ArrayLength(data) - 1);

becomes:

    mName.AssignLiteral(u"");

in the generated code.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1591514 part 1. Change bindings to use actual literal strings for string constants. r=mccr8

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1591514 part 2. Add assertions to FakeString that its mData is only initialized once and not used before initialization. r=mccr8

Also removes some unused API bits to make the number of entry points smaller
and safer.

Comment 3

[Boris Zbarsky [:bzbarsky]]

    mName.AssignLiteral(u"");

I guess we could also try to special-case the empty-string common case to just call Truncate...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eed1acc4c779
part 1.  Change bindings to use actual literal strings for string constants.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e91fee31774b
part 2.  Add assertions to FakeString that its mData is only initialized once and not used before initialization.  r=mccr8

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/eed1acc4c779
https://hg.mozilla.org/mozilla-central/rev/e91fee31774b

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eed1acc4c779
https://hg.mozilla.org/integration/mozilla-inbound/rev/e91fee31774b