1591565 - Remove the SecondaryPanes footer to save some space

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Florens Verschelde :fvsch]

When docked to the bottom, the DevTools toolbox can be rather squat, and we have very little vertical screen estate in the SecondaryPanes sidebar.

So it strikes me that we're spending a full 25px of that space on a footer bar that just contains one icon.

I suggest removing that bottom bar altogether, and figuring out what we can do with that "Keyboard shortcuts" icon:

1. Remove it completely, since we can call the Keyboard Shortcuts from the Welcome screen?
2. Move it to the Editor's footer?

I kinda like option #1 myself.

Comment 1

[Florens Verschelde :fvsch]

Attachment: debugger-docked-bottom.png

Screenshot taken with the pref devtools.toolbox.footer.height set to 316.

The default value is a tiny 250, so even smaller than that!

Comment 2

[Florens Verschelde :fvsch]

Attachment: debugger-docked-right.png

When docked to the side, things can be a bit better, though that's still a lot of wasted space.

Comment 3

[Florens Verschelde :fvsch]

Attachment: Bug 1591565 - Remove the SecondaryPanes footer; r=jlast

Comment 4

[Florens Verschelde :fvsch]

Discussed with jlast: moving the Shortcuts button to the Editor footer is not necessary because the Welcome screen has a similar button, and the Editor footer can be cramped already.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b12c5d431cda
Remove the SecondaryPanes footer; r=jlast

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b12c5d431cda