Closed Bug 1591650 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 19916 - [infrastructure] Opt-in to single-page test feature

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 19916 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19916
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:

[infrastructure] Opt-in to single-page test feature

testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.

Update the tests which previously opted in implicitly to use the new
API.

[1] https://github.com/web-platform-tests/wpt/pull/19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 6 tests and 6 subtests

Firefox

OK : 4
PASS : 3
FAIL : 3
ERROR: 2

Chrome

OK : 4
PASS : 3
FAIL : 3
ERROR: 2

Safari

OK : 4
PASS : 3
FAIL : 3
ERROR: 2

New tests that's don't pass

/infrastructure/expected-fail/unhandled-rejection-single-test.html
Unhandled rejection in single-page test: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

/infrastructure/expected-fail/uncaught-exception-single-test.html
Uncaught exception in single-page test: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

/infrastructure/expected-fail/uncaught-exception-following-subtest.html: Firefox: ERROR, Chrome: ERROR, Safari: ERROR

/infrastructure/expected-fail/unhandled-rejection-following-subtest.html: Firefox: ERROR, Chrome: ERROR, Safari: ERROR

Automatic update from web-platform-tests
[infrastructure] Refactor tests & extend coverage (#19916)

testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.

Update some tests which previously opted in implicitly to use the new
API. Update others to instead declare a single subtest (so that they are
no longer single-page tests). Add new tests to fully cover the
conditions under which an uncaught exception or unhandled rejection
could occur.

[1] https://github.com/web-platform-tests/wpt/pull/19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

wpt-commits: b00f6989a451cd003d04463a82918973fcd3fa53
wpt-pr: 19916

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/225b21e209e5
[wpt PR 19916] - [infrastructure] Refactor tests & extend coverage, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3ce646c363e0
[wpt PR 19916] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.