Closed
Bug 1591655
Opened 5 years ago
Closed 5 years ago
Remove the useless proto argument to JS::NewPromiseObject
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
It defaults to nullptr, and every caller either omits it or passes nullptr. (Note also that the argument failed to be respected if !executor, too.) No reason not to get rid of it, and also to get rid of a similarly-vacuous argument in DOM-side callers.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jwalden
Status: NEW → ASSIGNED
|
||
Updated•5 years ago
|
Attachment #9104387 -
Attachment description: Bug 1591655 - Remove the unnecessary |proto| argument from |JS::NewPromiseObject| and its callers, seeing as all callers pass |nullptr| (and therefore uniformly request the default prototype). r?jandem!,bzbarsky! → Bug 1591655 - Remove the unnecessary |proto| argument from |JS::NewPromiseObject| and its callers, seeing as all callers pass |nullptr| (and therefore uniformly request the default prototype). r=bzbarsky, r=jandem
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/adfac78ca4eb Remove the unnecessary |proto| argument from |JS::NewPromiseObject| and its callers, seeing as all callers pass |nullptr| (and therefore uniformly request the default prototype). r=jandem,bzbarsky
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•