1591761 - parseXULToFragment needs to handle non-well-formed XML

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Alex Vincent [:WeirdAl]]

I accidentally passed some not-well-formed XML (specifically, forgetting to replace & with & in a URL string) into MozXULElement.parseXULToFragment. The error I got back was not helpful:

JavaScript error: , line 0: uncaught exception: Object

If you do this, the DOMParser will return a <parsererror>...</parsererror> document, but one without a XUL box root element. Then it reaches the selectNodeContents(null) line and throws an exception.

Testcase coming.

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: Bug 1591761 - parseXULToFragment should throw a clearer exception for non-well-formed markup. r=bgrins

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8799781bbf34
parseXULToFragment should throw a clearer exception for non-well-formed markup.  r=bgrins

Comment 3

[Oana Pop-Rus]

Backed out changeset 8799781bbf34 (bug 1591761) for causing mass test failures.

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=8799781bbf3490a6f8c58c7de511dac360be6bb5&selectedJob=273367148

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273367148&repo=autoland&lineNumber=1090

Backout: https://hg.mozilla.org/integration/autoland/rev/a09c768d2dc0649a82c15788e5a33052616d7f16

Comment 4

[Alex Vincent [:WeirdAl]]

One of the changes in the Phabricator request was both unnecessary and broke the parseXULToFragment code. Fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2362ccd868c6
parseXULToFragment should throw a clearer exception for non-well-formed markup.  r=bgrins

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2362ccd868c6

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2362ccd868c6