Closed Bug 1591829 Opened 5 years ago Closed 4 years ago

Unexpected save prompt in calendar tests

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

Since switching to mochitest we've been plagued by save prompts appearing when they shouldn't.

The problem is caused by the Mozmill helper function for dealing with menus. It simulates a keypress on the Escape key. It fails when the dialog gets control of the event loop (something causes the test to wait) and processes this event, but the test has already moved on (so some other part of the dialog is now active and doesn't handle the Escape key, and it propagates to the top).

Here's a Try run I did with a slightly different but basically the same change. I've also put in a sleep call near the annoying all-day checkbox that keeps failing, on the theory that that is caused by a similar problem.

TLDR: We're making these tests run in a way that was never intended.

Attachment #9104553 - Flags: review?(paul)
Attachment #9104553 - Flags: approval-calendar-beta?(paul)
Attachment #9104553 - Flags: review?(paul)
Attachment #9104553 - Flags: review+
Attachment #9104553 - Flags: approval-calendar-beta?(paul)
Attachment #9104553 - Flags: approval-calendar-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2e016c75c928
Prevent unexpected save prompt in calendar tests. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 72
You need to log in before you can comment on or make changes to this bug.