Unexpected save prompt in calendar tests
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
1.87 KB,
patch
|
pmorris
:
review+
pmorris
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
Since switching to mochitest we've been plagued by save prompts appearing when they shouldn't.
Assignee | ||
Comment 1•5 years ago
|
||
The problem is caused by the Mozmill helper function for dealing with menus. It simulates a keypress on the Escape key. It fails when the dialog gets control of the event loop (something causes the test to wait) and processes this event, but the test has already moved on (so some other part of the dialog is now active and doesn't handle the Escape key, and it propagates to the top).
Here's a Try run I did with a slightly different but basically the same change. I've also put in a sleep
call near the annoying all-day checkbox that keeps failing, on the theory that that is caused by a similar problem.
TLDR: We're making these tests run in a way that was never intended.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2e016c75c928
Prevent unexpected save prompt in calendar tests. r=pmorris
Updated•4 years ago
|
Comment 3•4 years ago
|
||
TB 71 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/4820421dbf43d8325038dab2f5070cc60268533f
Description
•