1591874 - Move VariablesView files to devtools/client/storage

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

After Scratchpad removal, the storage inspector will be the last consumer of the VariableView.
Let's move it to the storage inspector folder so it's obvious it does not have any other consumers.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1591874 - Move VariablesView files to devtools/client/storage. r=miker.

Since the storage inspector is the last consumer of the VariablesView,
it makes sense to move the component directly in the storage inspector
folder.
Since it can't have a controller, the bits where we were checking this
are removed.

Depends on D54733

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dc649a6a711
Move VariablesView files to devtools/client/storage. r=miker.

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on storage/moz.build

Backout link: https://hg.mozilla.org/integration/autoland/rev/ad5a005cee3ed9d6f883dc8312cc8fd24dce28b3
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279272756&repo=autoland&lineNumber=1280

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

sorry, there was something wrong in how I moved the file.
I updated the patch and pushed to TRY to make sure everything is okay

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b5282256e00
Move VariablesView files to devtools/client/storage. r=miker.

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1529917, Bug 1591874) for causing bustages in VariablesView.jsm

Backout link: https://hg.mozilla.org/integration/autoland/rev/4cf52729f132bf19c9465044d4f0e14b9cca25de

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&tochange=4cf52729f132bf19c9465044d4f0e14b9cca25de&fromchange=0b5282256e0094eeae41d6c6377c6b37893cbf06&selectedJob=279319506

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279319506&repo=autoland&lineNumber=1390

[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - mozbuild.frontend.reader.SandboxValidationError:
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - ==============================
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - FATAL ERROR PROCESSING MOZBUILD FILE
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - ==============================
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - The error occurred while processing the following file or one of the files it includes:
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - /builds/worker/workspace/build/src/devtools/client/storage/moz.build
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - The error occurred when validating the result of the execution. The reported error is:
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - File listed in FINAL_TARGET_FILES does not exist: /builds/worker/workspace/build/src/devtools/client/storage/VariablesView.jsm

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faeca320475a
Move VariablesView files to devtools/client/storage. r=miker.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7f97f586d04
Move VariablesView files to devtools/client/storage. r=miker.

Comment 9

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1529917, Bug 1591874) for ESlint failure on VariablesView.jsm.
https://hg.mozilla.org/integration/autoland/rev/15c693744f0c3e65ea3f60831f816e836741b753

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=a7f97f586d04b2063c1d4efc41ea043c7e275ec1&selectedJob=279364277

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279364277&repo=autoland&lineNumber=54

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3835aab3ce21
Move VariablesView files to devtools/client/storage. r=miker.

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3835aab3ce21