Closed Bug 1591875 Opened 5 years ago Closed 5 years ago

Break Browsertime's `run_test` method into multiple specific methods

Categories

(Testing :: Raptor, enhancement, P2)

Product:
Testing
Component:
Raptor
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: onegru, Unassigned)

References

(Blocks 1 open bug)

Details

Target file:
raptor.py

Target class:
-Browsertime

Target method:
def run_test(self, test, timeout)

Reason: the logic related to bt_timeout, cmd variables is hard to test and bugs can hide there

Extract into new methods the logic related to:
1.bt_timeout variable calculations
2.cmd variable formation
3.env variable setting

If there are any improvements related to run_test method, they can be done in this bug.

Is this still valid? If not please close, thanks :)

Blocks: browsertime-ci
Flags: needinfo?(onegru)

Yes, it can be closed.

Flags: needinfo?(onegru)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.