1591908 - Limit tooltip for WS payload in Messages panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Tooltips in the Messages panel (displaying WS payload) can be too big. Let's introduce a logic that limits them.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:

1. Load https://socket.io/
2. Select the Network panel and reload the page
3. Set the WS filter button in the Toolbar to make it easier to find 101 requests
4. Select the 101 request and look at the Messages panel
5. Wait for a frame with bigger payload body
6. Hover over the raw in the WS frame list -> displayed tooltip is big and broken -> BUG

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

See the attached screenshot showing broken tooltip.
Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some instructions for anyone interested in fixing this bug:

1. The fix can be very similar to what we did for the Search panel tooltips.
   https://phabricator.services.mozilla.com/D47516

2. Here is where the tooltip is rendered
   https://searchfox.org/mozilla-central/rev/74cc0f4dce444fe0757e2a6b8307d19e4d0e0212/devtools/client/netmonitor/src/components/websockets/FrameListColumnData.js#33

Honza

Comment 4

[Release mgmt bot [:suhaib / :marco/ :calixte]]

:Honza, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Comment 5

[Harsh]

Hi @Honza. Can I take up this issue?

Comment 6

[Vitalii]

Attachment: Bug 1591908 - Limit websocket tooltips

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79cc8a9b30e8
Limit websocket tooltips r=Honza

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/79cc8a9b30e8

Comment 9

[Anca Soncutean [:Anca], Desktop Release QA]

Attachment: Nightly_76.png

I can still reproduce this issue on Ubuntu 18.04 with the latest Nightly (see the attached screenshot)

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Looking at the screenshot, the tooltip is big but, not broken correct?
According to the last three dots (...) in the tooltip, it looks like the patch is properly applied.
Honza

Comment 11

[Anca Soncutean [:Anca], Desktop Release QA]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #10)

Looking at the screenshot, the tooltip is big but, not broken correct?

Correct, I was focusing on the size of the tooltip there, but while most of them end with (..) I can still see tooltips like the following: https://drive.google.com/file/d/1fRktNDja0Cll69zQrneUoJBc5ehjBlVz/view?usp=sharing

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Ah, I see it on the screenshot now. So, yes, this looks like a bug.
Can you please file a follow up bug, this should be fixed.

Thanks,
Honza

Comment 13

[Anca Soncutean [:Anca], Desktop Release QA]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #12)

Ah, I see it on the screenshot now. So, yes, this looks like a bug.
Can you please file a follow up bug, this should be fixed.

Thanks,
Honza

Filled bug 1626189!