Show size only in plain WebSocket message sections, not preview
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(firefox73 fixed)
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: Harald, Assigned: cabezota)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(3 files)
image.png
Showing it on all tabs is redundant and on Raw it makes most sense.
|
||
Comment 1•5 years ago
|
||
Here is the place where the label (including the size info) is generated:
https://searchfox.org/mozilla-central/rev/74cc0f4dce444fe0757e2a6b8307d19e4d0e0212/devtools/client/netmonitor/src/components/websockets/FramePayload.js#162,185
Honza
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 2•5 years ago
|
||
- Removed the second argument L10N.getFormatStrWithNumbers in https://searchfox.org/mozilla-central/rev/74cc0f4dce444fe0757e2a6b8307d19e4d0e0212/devtools/client/netmonitor/src/components/websockets/FramePayload.js#162,185
- Removed (%S) in https://searchfox.org/mozilla-central/source/devtools/client/locales/en-US/netmonitor.properties#697
Should I add a test for these changes? If so, what kind? I'm not sure how to find the tests that cover this part of the code
|
|
Assignee | |
Comment 3•5 years ago
|
||
Now it looks like this https://i.ibb.co/nstt0qt/screenshot-from-2019-10-30-23-53-38.png
|
Reporter | |
Comment 4•5 years ago
|
||
Thanks so much, Andres!
Now it looks like this https://i.ibb.co/nstt0qt/screenshot-from-2019-10-30-23-53-38.png
One nit, could we show the size on raw data, not the formatted section?
|
|
Assignee | |
Comment 7•5 years ago
|
||
Show the size only in Raw Data, because showing it on all tabs is redundant and on Raw makes most sense.
|
|
Assignee | |
Comment 8•5 years ago
|
||
Show the size only in Raw Data, because showing it on all tabs is redundant and on Raw makes most sense.
|
|
||
Comment 9•5 years ago
|
||
Please rebase the patch on top of the latest m-c.
See also my comment in Phabricator
https://phabricator.services.mozilla.com/D52607#1606475
|
|
Assignee | |
Comment 10•5 years ago
|
||
I updated the revision with the rebase https://phabricator.services.mozilla.com/D52607#1606475
|
||
Comment 11•5 years ago
|
||
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9393fc623a98 Show size only in Raw Data of WebSocket message section. r=Honza
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
Description
•