1591912 - Separate the different `InvalidValue` error case for `TimingDistributionMetricType`s

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Alessio Placitelli [:Dexter]]

In bug 1591153 we found that some timing distributions are detecting errors: however, the "invalid value" error can be triggered due to samples being negative or lasting more than 10 minutes.

We should consider adding a way to tell these cases apart.

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: GitHub Pull Request

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: glean_invalid_overflow_error.md

Comment 3

[Chris H-C :chutten]

Comment on attachment 9115724 [details]
glean_invalid_overflow_error.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is documented in [the Book of Glean](https://mozilla.github.io/glean/book/user/error-reporting.html).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the preferences or settings of the products embedding the Glean SDK.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Alessio Placitelli is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 4

[Alessio Placitelli [:Dexter]]

This was just merged, I've also forked the Fenix Nightly Errors query to account for the new error type. It's here.

I won't close this bug yet: tomorrow I'll cut a new release and merge it in A-C.

Comment 5

[Alessio Placitelli [:Dexter]]

Attachment: Version bump in A-C