1591990 - Enable some local storage tests for Fission

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, task, P1)

Description

[Yaron Tausky [:ytausky]]

The following tests pass when run with Fission and need to be enabled:

• dom/tests/mochitest/localstorage/test_keySync.html
• dom/tests/mochitest/localstorage/test_localStorageOriginsDiff.html
• dom/tests/mochitest/localstorage/test_localStorageOriginsDomainDiffs.html
• dom/tests/mochitest/localstorage/test_localStorageOriginsEquals.html
• dom/tests/mochitest/localstorage/test_localStorageOriginsPortDiffs.html
• dom/tests/mochitest/localstorage/test_localStorageOriginsSchemaDiffs.html

Note that this has already been done once in bug 1576233, but was reverted in bug 1576814.

Comment 1

[Yaron Tausky [:ytausky]]

Attachment: Bug 1591990 - Enable local storage tests for Fission

These tests now pass when run under Fission.

Comment 2

[Neha Kochar [:neha]]

Yaron, these tests are marked as expected failures. If you run them locally, mochitest.ini is still respected for the fail-if tests (its different for the skip-if tests). So for running them locally, you'll also need to remove the respective fail-if(s) from the mochitest.ini file.
If an expected failing test starts passing in central, we'll see an orange for "unexpected success" and that will get enabled for fission pretty quickly. These tests haven't, indicating there's more work needed here.

Comment 3

[Yaron Tausky [:ytausky]]

Currently these tests pass for me both locally and on try. I'm still trying to figure out why they are not reported as unexpected passes locally and why they seem to fail on some machines.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8efb1f8fa3d
Enable local storage tests for Fission r=janv

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e8efb1f8fa3d

Comment 6

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732