Closed
Bug 1592051
Opened 6 years ago
Closed 6 years ago
Add JS_HAZ_GC_POINTER annotation to GCCellPtr
Categories
(Core :: JavaScript: GC, task, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
Details
Attachments
(1 file)
This pointer type encodes gc pointers as uintptr_t so we should explicitly mark it as JS_HAZ_GC_POINTER to inform the hazard analysis. There are two minor violations that snuck in, but one is in a gdb test and the other only accesses the gccellptr kind after a maybe-gc.
|
Assignee | |
Comment 1•6 years ago
|
||
This also fixes two inconsequential hazards.
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7377220a5ad
Mark GCCellPtr as JS_HAZ_GC_POINTER. r=sfink
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•