Closed Bug 1592189 Opened 3 months ago Closed 2 months ago

Remove internal SpecialColorKeyword enum in favor of SystemColor

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: Sam, Assigned: Sam)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0

Flags: needinfo?(emilio)

Move all the entires of SpecialColorKeyword into SystemColor
and rearrange their computation to match.
Add the new SystemColor entries into the property list of nsXPLookAndFeel.

Well, the needinfo was just if you needed me to fix it ;)

Flags: needinfo?(emilio)
Assignee: nobody → sam
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Unspecified → All
Priority: -- → P4
Hardware: Unspecified → All

I tried to land, but got the following:
Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmpOQt5GN widget/nsXPLookAndFeel.cpp Hunk #1 FAILED at 168. 1 out of 2 hunks FAILED -- saving rejects to file widget/nsXPLookAndFeel.cpp.rej servo/components/style/values/specified/color.rs Hunk #2 FAILED at 138. 1 out of 7 hunks FAILED -- saving rejects to file servo/components/style/values/specified/color.rs.rej abort: patch command failed: exited with status 256

Flags: needinfo?(sam)

Rebased and resubmitted for landing.

Flags: needinfo?(sam)
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6514e3ddd69b
Remove SpecialColorKeyword enum and merge into SystemColor r=emilio
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.