1592189 - Remove internal SpecialColorKeyword enum in favor of SystemColor

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Sam Mauldin (:Sam)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0

Comment 1

[Sam Mauldin (:Sam)]

Attachment: Bug 1592189 - Remove SpecialColorKeyword enum and merge into SystemColor

Move all the entires of SpecialColorKeyword into SystemColor
and rearrange their computation to match.
Add the new SystemColor entries into the property list of nsXPLookAndFeel.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Well, the needinfo was just if you needed me to fix it ;)

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

I tried to land, but got the following:
Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmpOQt5GN widget/nsXPLookAndFeel.cpp Hunk #1 FAILED at 168. 1 out of 2 hunks FAILED -- saving rejects to file widget/nsXPLookAndFeel.cpp.rej servo/components/style/values/specified/color.rs Hunk #2 FAILED at 138. 1 out of 7 hunks FAILED -- saving rejects to file servo/components/style/values/specified/color.rs.rej abort: patch command failed: exited with status 256

Comment 4

[Sam Mauldin (:Sam)]

Rebased and resubmitted for landing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6514e3ddd69b
Remove SpecialColorKeyword enum and merge into SystemColor r=emilio

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6514e3ddd69b