1592202 - Browser Toolbox Debugger no longer lists Debugger Workers

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Logan Smyth [:loganfsmyth]]

Steps:

1. Open a tab and open the JS debugger
2. Open the browser toolbox

Expected:
The debugger in the browser toolbox should list all of the Worker's spawned by the debugger, like the parser worker and sourcemap workers.

Actual:
No workers are listed.

It looks like this is caused by https://hg.mozilla.org/integration/autoland/rev/375669bcc8c4b8e3761b87903b5d8d939f35e6fb.

There does appear to be some other weirdness though, because even when I set devtools.toolbox.content-frame, I seem to only intermittently see all of the workers, with them appearing briefly and then disappearing if I have the toolbox open and open and close the browser devtools.

@jdescottes Any idea what's going on here?

Comment 1

[Julian Descottes [:jdescottes]]

This reminds me of Bug 1577881 which was another debugger issue caused by the content-frame change. In the previous bug however, there was an error which doesn't seem to be the case here. (ccing Brian who fixed the other bug).

The main difference between type=content and type=chrome is that you can't reach the top chrome window by using window.top on the toolbox's window. Instead we use win.windowRoot.ownerGlobal. We tried to make sure all the call sites in DevTools that relied on this were updated but we might have missed some.
But I don't know enough about how workers are discovered to say if this is related to our problem or not.

There does appear to be some other weirdness though, because even when I set devtools.toolbox.content-frame,
I seem to only intermittently see all of the workers,

For me it doesn't seem intermittent, as soon as I toggle the pref (and close+reopen the toolbox) I can see parser-worker.js in the Browser Toolbox.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

Logan, is this still an issue?

I was quickly testing this and I can see three workers in Debugger (parser, pretty-print and search) and one in Network (search). I was also able to break in the Network-Search worker. See the screenshot.

Honza

Comment 3

[Brian Hackett [Laid off!]]

FWIW bug 1594597 fixed this for the OBT case at least.

Comment 4

[Logan Smyth [:loganfsmyth]]

I don't think this is fixed.

@Honza

The screenshot there shows the index files of the workers because the index files are the main-thread scripts that dispatch messages to the workers, but the workers themselves aren't listed and there is no "Workers" pane in the sidebar.

I'll attach some screenshots.

@Brian

Is the OBT the normal browser toolbox you'd get in FF? I'm not familiar.

Comment 5

[Logan Smyth [:loganfsmyth]]

Attachment: Current Browser Toolbox with no "Threads" list

Comment 6

[Logan Smyth [:loganfsmyth]]

Attachment: Browser Toolbox with "devtools.toolbox.content-frame: false"

Comment 7

[Brian Hackett [Laid off!]]

(In reply to Logan Smyth [:loganfsmyth] from comment #4)

Is the OBT the normal browser toolbox you'd get in FF? I'm not familiar.

The OBT is enabled by the devtools.browsertoolbox.fission preference, which is not the default but will be soon I think.

Comment 8

[Julian Descottes [:jdescottes]]

(In reply to Brian Hackett (:bhackett) from comment #7)

(In reply to Logan Smyth [:loganfsmyth] from comment #4)

Is the OBT the normal browser toolbox you'd get in FF? I'm not familiar.

The OBT is enabled by the devtools.browsertoolbox.fission preference, which is not the default but will be soon I think.

Correct, this is tracked by https://bugzilla.mozilla.org/show_bug.cgi?id=1588050

Comment 9

[Logan Smyth [:loganfsmyth]]

Got it. Alright, sounds good.