Remove useless continue; declaration
Categories
(Core :: Audio/Video: Playback, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: jeffinsam, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(2 files)
Filling as a good first bug to learn workflows.
As continue; is at the end of the loop, the declaration is useless
https://searchfox.org/mozilla-central/rev/11d9c7b7fa82fdfb8ac2a8f0864e9d8d5fe2b926/dom/media/MediaCache.cpp#2561
As the change is trivial, it is just to learn how to contribute to Firefox.
|
||
Updated•5 years ago
|
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
|
|
Reporter | |
Comment 2•5 years ago
|
||
We need a diff, not the full file
and please use Phabricator, not bugzilla for code submission!
|
||
Comment 3•5 years ago
|
||
There are so many branches in phabricator for this same code though! Which one should be changed? https://phabricator.services.mozilla.com/source/mozilla-central/repository/default/
I want to contribute , Please guide me how can i contribute?
|
|
Reporter | |
Comment 6•5 years ago
|
||
Sure, you should read the documentation, it should be easy to fix.
|
||
Comment 7•5 years ago
|
||
I am interested in working on this issue. Do we just need to remove the continue in MediaCache.cpp for this issue?
|
|
Reporter | |
Comment 8•5 years ago
|
||
yes, correct
|
|
||
Comment 9•5 years ago
|
||
Are there any tests available for MediaCache.cpp that I can run?
|
|
Reporter | |
Comment 10•5 years ago
|
||
Just build it, it will be enough as the change is trivial ;)
|
|
||
Comment 11•5 years ago
|
||
Okay perfect!
|
||
Comment 12•5 years ago
|
||
Is it fixed? If not then I would like to work on it as I'm just getting started with contributions.
|
Assignee | |
Comment 13•5 years ago
|
||
|
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 14•5 years ago
|
||
To other, I have similar issues like this one. please send me an email if you are interested!
|
||
Comment 15•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c10fb6eef908 Remove useless continue; declaration r=sylvestre
|
||
Comment 16•5 years ago
|
||
| bugherder | ||
Description
•