Closed
Bug 1592325
Opened 5 years ago
Closed 5 years ago
Use explicitly wrapping subtraction at one location in HashTable.h
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
Build the browser with unsigned-overflow sanitizing on -- it's not undefined, and sometimes it's intended, but EIBTI generally -- and you're gonna get spammed a bunch by a subtraction in hash table code of two hash codes that will probably half the time underflow. Easy to use the wrapping-subtraction function to fix it.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/6a2b2f52d15e Fix an unsigned-integer underflow in HashTable.h that's super-easy to trigger using affirmatively wrapping operations. r=froydnj
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•