Closed Bug 1592433 Opened 4 years ago Closed 4 years ago

Hoist Deferred Allocation mode from FunctionTreeHolder to ParseInfo

Categories

(Core :: JavaScript Engine, enhancement, P3)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mgaudet, Assigned: vadikant, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Attachments

(1 file)

Bug 1592433 - Hoist Deferred Allocation mode from FunctionTreeHolder to ParseInfo
47 bytes, text/x-phabricator-request
Details | Review

It's becoming increasingly clear that deferred allocation mode doesn't belong inside the FunctionTreeHolder and instead should be hoisted to the ParseInfo

Prerequisites

Before getting started, you'll want to

  • You Have a checkout of the Firefox source code
  • Make sure you can build SpiderMonkey
  • Read this walkthrough about how development works in Firefox

This bug is done when...

SpiderMonkey compiles with the changed code, and passes its tests.

Getting Help

Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into #jsapi on irc.mozilla.org.

Tips:

  • Searchfox.org lets you search the firefox source code base, and you can click on functions and search by -function- which will help you find places that need to be changed.
Assignee: nobody → vadikant
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56ac264094c4
Hoist Deferred Allocation mode from FunctionTreeHolder to ParseInfo r=mgaudet

https://hg.mozilla.org/mozilla-central/rev/56ac264094c4

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.