1592496 - Add move constructor&assignment to nsMainThreadPtrHandle

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Add move constructor&assignment to nsMainThreadPtrHandle to avoid a Release+AddRef when moving the RefPtr member.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1592496 - Add move constructor and assignment to nsMainThreadPtrHandle - r?froydnj

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1592496 - nsProxyRelease.h clean-up - r?froydnj

Small changes:

• Ordered #includes.
• Fixed some comments (obsolete remarks, or typos).
• Set nsMainThreadPtrHolder::mRawPtr from constructor initializers.
• Modernized nsMainThreadPtrHolder copy-prevention.
• Made nsMainThreadPtrHandle::get() const (consistent with others).
• Moved nsMainThreadPtrHandle private member to the end.
• Removed now-unused mozilla::PtrHolder and mozilla::PtrHandle aliases.

Depends on D51055

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/535dce0633af
Add move constructor and assignment to nsMainThreadPtrHandle - r=froydnj
https://hg.mozilla.org/integration/autoland/rev/3dcba4d6c816
nsProxyRelease.h clean-up - r=froydnj

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/535dce0633af
https://hg.mozilla.org/mozilla-central/rev/3dcba4d6c816

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/535dce0633af
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dcba4d6c816