1592555 - AudioMixer should not accept a null Receiver

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

Description

[Alex Chronopoulos [:achronop]]

Right now it is allowed to add a null receiver in AudioMixer's callback list. This would create a crash in AudioMixer::FinishMixing() . We should verify that the receiver is not null before adding it to the list.

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1592555 - Not allow adding a null receiver in the AudioMixer callback list. r?padenot

A null MixerCallbackReceiver in the AudioMixer callback list can create a crash when the AudioMixer::FinishMixing() is being called. Verify that the receiver is not null before adding it in the list.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02f6d5d52fa9
Not allow adding a null receiver in the AudioMixer callback list. r=padenot

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/02f6d5d52fa9