Crash in [@ libxul.so@0x8741e6 | libxul.so@0x8741c0 | libxul.so@0x8741c0 | libxul.so@0x8740f7 | libxul.so@0x86d82f | libxul.so@0x299828a | libxul.so@0x5d3b0e3 | libxul.so@0x5d3bc79 | libxul.so@0x5d3ba35 | libxul.so@0x898308 | libxul.so@0x6f33d37 | libx...
Categories
(Core :: General, defect)
Tracking
()
People
(Reporter: pascalc, Unassigned)
Details
(Keywords: crash)
Crash Data
This bug is for crash report bp-19779761-ca28-441c-93da-752de0191029.
Top 10 frames of crashing thread:
0 libxul.so libxul.so@0x8741e6
1 libxul.so libxul.so@0x8741c0
2 libxul.so libxul.so@0x8741c0
3 libxul.so libxul.so@0x8740f7
4 libxul.so libxul.so@0x86d82f
5 libxul.so libxul.so@0x299828a
6 libxul.so libxul.so@0x5d3b0e3
7 libxul.so libxul.so@0x5d3bc79
8 libxul.so libxul.so@0x5d3ba35
9 libxul.so libxul.so@0x898308
Reporter | ||
Comment 1•5 years ago
|
||
Linux crashes, there is a big spike on 71 beta (1000 crashes over the last days), I think those are crashes from downstream and not our builds.
Comment 2•5 years ago
|
||
The comments mention crashing after updating - "After the recent (10/28/19) update in Ubuntu 16.04 using the terminal, Firefox crashes and will not even start."
Comment 3•4 years ago
|
||
The priority flag is not set for this bug.
:tvandermerwe, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 4•4 years ago
|
||
This seems like an IndexedDB issue. Could you take a look to determine priority, Christoph? Thanks!
Comment 5•4 years ago
|
||
We probably crash here:
https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/xpcom/string/nsTSubstringTuple.cpp#23
Simon, can this be related to the string concatenation you saw on Mac in a different bug ?
Comment 6•4 years ago
|
||
(In reply to Jan Varga [:janv] from comment #5)
We probably crash here:
https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/xpcom/string/nsTSubstringTuple.cpp#23Simon, can this be related to the string concatenation you saw on Mac in a different bug ?
That might be. Note that the issue on Mac only occurred with some specific apple-clang version that someone used locally instead of the default one. But it might be that some distro uses a clang version that is similar to that.
However, nsTSubstringTuple is used at many places. So it is hard to tell if this is related.
Since there does not seem to be any debug info, I wonder how this was identified to be related to IndexedDB and how you got to the source code line. If you did, could you provide the full call stack? Then I might be able to judge better if this is related to the previous issue.
Comment 7•4 years ago
|
||
May be related to bug 1595360.
Comment 8•4 years ago
|
||
(In reply to Jan Varga [:janv] from comment #7)
May be related to bug 1595360.
Yes, indeed. As https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1850529, this happens only with clang-6, which is rather old, and might be caused by a compiler bug (which is also true for the previous MacOS issue). I suppose we don't support clang-6 anymore? (Note that this clang version will soon become impossible to use when we enable C++17) Interestingly, https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code mentions only minimum versions for MSVC and gcc explicitly.
Comment 9•4 years ago
|
||
So, if it's a compiler bug, there's not much to do here. There are not many crash reports anyway (recent crash reports).
Comment 10•4 years ago
|
||
We should check that, though. At least, the minimum supported clang version should be clarified (and we should have builds on treeherder with the minimum supported clang version, if there is a current mismatch), and we should probably ping the Ubuntu bug with that.
Nathan, can you provide a definitive answer to that and maybe amend the MDN page with that?
Comment 11•4 years ago
|
||
Our minimum supported Clang version is 5, which is sufficient for C++17 support (even if the C++17 support is not complete and/or buggy). There are already builds on treeherder that confirm that Firefox can be built with our minimum versions of GCC and Clang (though they are not tested in any way).
The MDN page needs to be updated for Clang 5 support, and will also need to be updated for GCC 7 support, which should be landing shortly. I will take care of both of those things.
As to clang 6 producing bad code, that's pretty much on Ubuntu. We can communicate that Ubuntu probably needs to look at patches like:
https://hg.mozilla.org/mozilla-central/rev/0d04a3f89940536d56cd5415a78316f0960e9f0a (if not already compiling with 6.0.1)
https://hg.mozilla.org/mozilla-central/rev/dfe8ab123e01667be489a20b253e3cd3b20c10bd
Comment 12•4 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #11)
Our minimum supported Clang version is 5, which is sufficient for C++17 support (even if the C++17 support is not complete and/or buggy). There are already builds on treeherder that confirm that Firefox can be built with our minimum versions of GCC and Clang (though they are not tested in any way).
Great, sorry I was mixing up gcc and clang version numbers required for C++17 support!
Updated•4 years ago
|
Comment 14•4 years ago
|
||
(In reply to Thyla van der Merwe from comment #4)
This seems like an IndexedDB issue. Could you take a look to determine priority, Christoph? Thanks!
Sorry for the lag on this one, I guess it turned out to be a dup after all. Clearing my ni? ...
Reporter | ||
Updated•4 years ago
|
Description
•