1592623 - Remove an useless namespace alias in BasicTableLayoutStrategy.cpp

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Opening as a good source but as it is trivial but interesting to learn our workflows

namespace alias decl 'css' is unused

Found by
http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-alias-decls.html

This line is useless:
https://searchfox.org/mozilla-central/rev/9df2ccc256fe54c314b34e52920471a0d04b283e/layout/tables/BasicTableLayoutStrategy.cpp#27

To potential contributors, some advice:

• please read the doc
• please propose a patch on phabricator, I will assign the bug once it is done

Comment 1

[lana.elsanyoura]

Hello, could I work on this bug?

Would need to do is delete that unused line?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Correct!

Comment 3

[Sohaib]

Can I work on this bug ?

Comment 4

[lana.elsanyoura]

I’m already submitting the fix, sorry @Sohaib!

Comment 5

[Sylvestre Ledru [:Sylvestre]]

I’m already submitting the fix, sorry @Sohaib!

Sorry but I don't see it?

Comment 6

[iamhp2k]

is Issue Solved? If Not I am Ready

Comment 7

[Sundeep Chand]

Can I work on this?

Comment 8

[ian_tong]

I would like to be assigned to the bug if it's open.

Comment 9

[jeffinsam]

Attachment: Bug 1592623 - Remove an useless namespace alias in BasicTableLayoutStrategy.cpp r=Sylvestre

Depends on D52485

Comment 10

[ian_tong]

Attachment: Bug 1592623 - hello ian

Comment 11

[ian_tong]

Attachment: Bug 1592623 - Removed an useless namespace alias r=Sylvestre

Comment 12

[ian_tong]

Hello Sylvestre, I have submitted the fix. Please take a look, thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57764b69e8ed
Removed an useless namespace alias r=sylvestre

Comment 14

[Sylvestre Ledru [:Sylvestre]]

To other, I have similar issues like this one. please send me an email if you are interested!

Comment 15

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/57764b69e8ed